feat(integrations): Add http.route attribute to server spans - #7183
Open
mjq wants to merge 2 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ 118671 passed | ⏭️ 6732 skipped | Total: 125403 | Pass Rate: 94.63% | Execution Time: 413m 31s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 98.15%. Project has 2478 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.23% 90.29% +0.06%
==========================================
Files 193 193 —
Lines 25482 25527 +45
Branches 9384 9408 +24
==========================================
+ Hits 22994 23049 +55
- Misses 2488 2478 -10
- Partials 1431 1430 -1Generated by Codecov Action |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
mjq
force-pushed
the
mjq/http-route-server-spans
branch
from
August 13, 2026 20:16
dddf367 to
b1363a5
Compare
mjq
added a commit
that referenced
this pull request
Aug 24, 2026
…#7201) The sync request/response handler passed the _isolation_ scope to `_set_transaction_name_and_source`, but the transaction/segment span lives on the _current_ scope. As a result the route-resolved name never reached the span for sync endpoints, which were instead named by the raw URL from the ASGI middleware (`transaction_info.source` of `url` rather than `route`). Async handlers already used the current scope and were unaffected. Pass the current scope (already computed above) so sync and async handlers behave identically: - streaming: the segment name / `sentry.segment.name.source` are route-based - static: the transaction event name / source are route-based For parametrized routes this also removes high-cardinality URL transaction names for sync endpoints. Found while working on #7183.
sentrivana
pushed a commit
that referenced
this pull request
Aug 25, 2026
…#7201) The sync request/response handler passed the _isolation_ scope to `_set_transaction_name_and_source`, but the transaction/segment span lives on the _current_ scope. As a result the route-resolved name never reached the span for sync endpoints, which were instead named by the raw URL from the ASGI middleware (`transaction_info.source` of `url` rather than `route`). Async handlers already used the current scope and were unaffected. Pass the current scope (already computed above) so sync and async handlers behave identically: - streaming: the segment name / `sentry.segment.name.source` are route-based - static: the transaction event name / source are route-based For parametrized routes this also removes high-cardinality URL transaction names for sync endpoints. Found while working on #7183.
mjq
force-pushed
the
mjq/http-route-server-spans
branch
from
August 26, 2026 20:10
b1363a5 to
1d15a6d
Compare
mjq
changed the title
http.route attribute to HTTP server spans
mjq
commented
Aug 27, 2026
| for attribute, value in attributes.items(): | ||
| self.set_attribute(attribute, value) | ||
|
|
||
| def set_segment_attribute(self, key: str, value: "AttributeValue") -> None: |
Member
Author
There was a problem hiding this comment.
This seemed like a useful helper function to have (and avoids duplicating this code in every HTTP integration), but I would also understand if we don't want to expand the API surface with this: it makes the "segment" name a public thing which AIUI we are trying to avoid?
sentrivana
pushed a commit
that referenced
this pull request
Aug 27, 2026
### Description When host routing, we don't have a route and instead fall back to the request path for the transaction name. This should be given transaction source `url` (for raw URLs) instead of the current value of `route` (for parameterized routes). This matters for #7183, where the mis-categorized transaction source would lead to bad data in `http.route`. (Bug found by Cursor in #7183 (comment) when reviewing that PR).
mjq
marked this pull request as ready for review
August 27, 2026 18:42
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fdd83b4. Configure here.
| if http_route is not None: | ||
| current_span._segment.set_attribute( | ||
| SPANDATA.HTTP_ROUTE, http_route | ||
| ) |
There was a problem hiding this comment.
Aiohttp skips scope transaction update
Medium Severity
Switching to traces.get_current_span() makes the streaming branch actually run, but that path only mutates the span and never calls set_transaction_name. Error events still read the scope’s _transaction, which stays at the generic fallback, so captured exceptions can be grouped and linked under the wrong name.
Reviewed by Cursor Bugbot for commit fdd83b4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the HTTP path template is only available in the span name. Make it available as a semantic attribute as well (
http.route- definition in conventions).This will also let us use this in e.g. HTTP server span
descriptiongeneration, which will be necessary to maintain consistent descriptions between transactions and span streaming.Issues
http.routemissing from HTTP server spans #7182